[prometheus-json-exporter]: Add extraContainers field
#5828
+41
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w sidecars to be defined for `prometheus-json-exporter` Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
rvandernoort
changed the title
extraContainers field to json-exporterextraContainers field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds
extraContainersfield tojson-exporterto values and deployments to allow sidecars to be defined for
prometheus-json-exporterWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)extraContainers#5827Special notes for your reviewer
Thanks for reviewing, I hope this PR gets accepted since this would simplify my desired deployment!
Checklist
[prometheus-couchdb-exporter])