Skip to content

[prometheus-sql-exporter]: remove ref to unused role and rolebinding #5837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

KyriosGN0
Copy link
Contributor

Signed-off-by: AvivGuiser avivguiser@gmail.com

What this PR does / why we need it

remove the role and rolebinding since the psp object doesn't exist

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@KyriosGN0 KyriosGN0 requested a review from wilfriedroset as a code owner June 26, 2025 22:21
@wilfriedroset
Copy link
Contributor

good catch thank you.
I'll let the PR open in case someone else wants to take a look.

@DrFaust92
Copy link
Contributor

LGTM, merging

@DrFaust92 DrFaust92 merged commit dbe51c1 into prometheus-community:main Jul 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants