Skip to content

SQL in analyst testing #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: qa
Choose a base branch
from
Open

SQL in analyst testing #3038

wants to merge 2 commits into from

Conversation

luke-quadratic
Copy link
Contributor

Description

DISCLAIMER: This PR should be re-written from scratch for whatever actually gets shipped; this PR is purely for scoping and testing how well this feature will work with varying context.

@luke-quadratic luke-quadratic added the prototype exploring an idea that can be played with label Jun 6, 2025
Copy link

qa-wolf bot commented Jun 6, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Jun 6, 2025
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Preview - Build, Deploy & Tests-E2E

✅ Build images
✅ Deploy images - Jun 06, 2025 at 02:18 PM UTC - Preview
❌ Tests-E2E - Report

@github-actions github-actions bot temporarily deployed to preview-pr-3038 June 6, 2025 01:27 Destroyed
.join('\n')}

You can create new SQL code cells using these database connections. When creating SQL code cells, use the connection ID in the language parameter like this:
{"Connection": {"kind": "${schemasArray[0]?.kind || 'POSTGRES'}", "id": "connection-uuid"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example uses a hardcoded placeholder "connection-uuid" which the AI might interpret as a literal value to use in generated code. To prevent this confusion, replace it with the actual connection ID from the first schema in the array:

{"Connection": {"kind": "${schemasArray[0]?.kind || 'POSTGRES'}", "id": "${schemasArray[0]?.id}"}}

This ensures the AI will generate SQL cells with valid connection IDs from the available schemas.

Suggested change
{"Connection": {"kind": "${schemasArray[0]?.kind || 'POSTGRES'}", "id": "connection-uuid"}}
{"Connection": {"kind": "${schemasArray[0]?.kind || 'POSTGRES'}", "id": "${schemasArray[0]?.id}"}}

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (f019565) to head (94685af).
Report is 2 commits behind head on qa.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #3038      +/-   ##
==========================================
- Coverage   91.06%   91.06%   -0.01%     
==========================================
  Files         401      401              
  Lines       93279    93374      +95     
==========================================
+ Hits        84949    85033      +84     
- Misses       8330     8341      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luke-quadratic luke-quadratic mentioned this pull request Jun 6, 2025
4 tasks
@luke-quadratic luke-quadratic linked an issue Jun 6, 2025 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed prototype exploring an idea that can be played with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL in left chat
1 participant