-
Notifications
You must be signed in to change notification settings - Fork 235
SQL in analyst testing #3038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: qa
Are you sure you want to change the base?
SQL in analyst testing #3038
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
.join('\n')} | ||
|
||
You can create new SQL code cells using these database connections. When creating SQL code cells, use the connection ID in the language parameter like this: | ||
{"Connection": {"kind": "${schemasArray[0]?.kind || 'POSTGRES'}", "id": "connection-uuid"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example uses a hardcoded placeholder "connection-uuid"
which the AI might interpret as a literal value to use in generated code. To prevent this confusion, replace it with the actual connection ID from the first schema in the array:
{"Connection": {"kind": "${schemasArray[0]?.kind || 'POSTGRES'}", "id": "${schemasArray[0]?.id}"}}
This ensures the AI will generate SQL cells with valid connection IDs from the available schemas.
{"Connection": {"kind": "${schemasArray[0]?.kind || 'POSTGRES'}", "id": "connection-uuid"}} | |
{"Connection": {"kind": "${schemasArray[0]?.kind || 'POSTGRES'}", "id": "${schemasArray[0]?.id}"}} |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #3038 +/- ##
==========================================
- Coverage 91.06% 91.06% -0.01%
==========================================
Files 401 401
Lines 93279 93374 +95
==========================================
+ Hits 84949 85033 +84
- Misses 8330 8341 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
DISCLAIMER: This PR should be re-written from scratch for whatever actually gets shipped; this PR is purely for scoping and testing how well this feature will work with varying context.