Add tracing mapping fields into kafka_franz #2836
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @jeongukjae, nice work on this! Did you sign the CLA yet? It would be amazing if we could get this feature added. Thanks in advance! 🙏 |
jeongukjae
force-pushed
the
add-tracing-to-other-kafkas
branch
from
da2c27f to
c68338b
Compare
jeongukjae
force-pushed
the
add-tracing-to-other-kafkas
branch
from
c68338b to
c3c0453
Compare
|
@rob-ellison-jet Hi, signed CLA and rebased. |
|
Hi @Jeffail, Sorry to tag you directly but not sure what the process is to get this workflow approved and get this added. It would be great to include this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates kafka_franz plugin to support inject_tracing_map & extract_tracing_map.
Fix #2690
Fix #1923
Fix #1647