-
-
Notifications
You must be signed in to change notification settings - Fork 525
feat(notif): add ntfy agent #4141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for ntfy notifications by introducing a new settings page, integrating ntfy into the backend, and updating documentation.
- Introduce a Next.js page and form component for configuring ntfy notifications
- Register ntfy in server settings, routes, and as a notification agent
- Add ntfy docs and update the notifications navigation
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/pages/settings/notifications/ntfy.tsx | New page component for ntfy notification settings |
src/components/Settings/SettingsNotifications.tsx | Include ntfy in the notifications navigation tabs |
src/components/Settings/Notifications/NotificationsNtfy/index.tsx | New form component with validation and test button |
server/routes/settings/notifications.ts | Added GET/POST/test endpoints for ntfy settings |
server/lib/settings.ts | Defined NotificationAgentNtfy and default settings |
server/lib/notifications/agents/ntfy.ts | Implemented NtfyAgent with payload construction |
server/index.ts | Registered NtfyAgent on application startup |
docs/using-overseerr/notifications/ntfy.md | Documentation for ntfy configuration |
docs/using-overseerr/notifications/README.md | Added ntfy to the list of supported agents |
Files not reviewed (2)
- overseerr-api.yml: Language not supported
- src/i18n/locale/en.json: Language not supported
Comments suppressed due to low confidence (2)
src/components/Settings/Notifications/NotificationsNtfy/index.tsx:29
- New component
NotificationsNtfy
lacks unit or integration tests; consider adding tests for form validation, API calls, and the test-notification flow.
const NotificationsNtfy = () => {
server/routes/settings/notifications.ts:417
- New ntfy API routes are not covered by any tests; consider adding route tests to verify GET, POST, and test endpoints.
notificationRoutes.get('/ntfy', (_req, res) => {
src/components/Settings/Notifications/NotificationsNtfy/index.tsx
Outdated
Show resolved
Hide resolved
6398fe1
to
4df5988
Compare
4df5988
to
bbf42fb
Compare
Description
adds support for ntfy notifications
heavily inspired by #2196
Screenshot (if UI-related)
To-Dos
yarn build
yarn i18n:extract