fix(StarryNight) Top Banner Margin #1193
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call to grid-template-areas on `.global-nav` and `.Root__top-container` was missing a reference to top-banner, causing layout issues.
Previous fix seemed to bug sidebar. Swapping out one of the calls to global nav with a call to top-banner instead of adding a new line seems to fix. Likely to cause problems elsewhere, review / testing needed.
|
|
kyrie25
reviewed
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call to the
grid-template-areasproperty on.global-navand.Root__top-containerwas missing a reference to top-banner, causing layout issues in Starry Night. This may or may not be the final location of this bug..