Skip to content

chore: fix eslint config errors #13916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2025
Merged

chore: fix eslint config errors #13916

merged 4 commits into from
Jun 30, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jun 23, 2025

This PR updates some deps and configs to fix some eslint errors. It also updates the eslint config type to remove the TypeScript error.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 23, 2025

⚠️ No Changeset found

Latest commit: 08f9dae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eltigerchino eltigerchino marked this pull request as draft June 23, 2025 09:31
@eltigerchino eltigerchino marked this pull request as ready for review June 24, 2025 04:29
"module": "ESNext"
"module": "ESNext",
"checkJs": true,
"noEmit": true
Copy link
Member Author

@eltigerchino eltigerchino Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkJs is required by typescript-eslint to parse the .svelte.js files. noEmit is required to prevent overwriting those js files

@eltigerchino eltigerchino changed the title chore: bump @sveltejs/eslint-config chore: fix eslint errors Jun 24, 2025
@eltigerchino eltigerchino changed the title chore: fix eslint errors chore: fix eslint config errors Jun 24, 2025
@benmccann benmccann merged commit 8b93550 into main Jun 30, 2025
18 checks passed
@benmccann benmccann deleted the fix-eslint-config branch June 30, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants