Skip to content

Conversation

thecoons
Copy link
Contributor

@thecoons thecoons commented Jun 10, 2025

Description

Currently, the only way to configure the target endpoint for the Azure AI Search vector store is through the environment variable AZURE_AI_SEARCH_ENDPOINT.
This PR adds the ability to configure the endpoint during store construction, consistent with other configuration options.

Existing implementation

https://github.com/tmc/langchaingo/blob/main/vectorstores/chroma/options.go#L35

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@Jiehong
Copy link

Jiehong commented Jun 11, 2025

As discussed in our chat, this change LGTM.

@tmc Hi, is this PR acceptable? We're starting to use this lib, and we are realising the Azure part is not as easy to use as we thought.

We would like to make more PRs to improve that. Would that be ok?

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM.

@tmc tmc merged commit 4298f6f into tmc:main Jun 21, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants