-
Notifications
You must be signed in to change notification settings - Fork 752
fix(traceloop-sdk): Replace Pydantic 'Config' class with model_config for v2 compatibility #3028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(traceloop-sdk): Replace Pydantic 'Config' class with model_config for v2 compatibility #3028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 1bcf10b in 1 minute and 26 seconds. Click for details.
- Reviewed
606
lines of code in57
files - Skipped
0
files when reviewing. - Skipped posting
3
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/traceloop/sdk/prompts/model.py:12
- Draft comment:
Nice implementation for Pydantic v2 compatibility usingmodel_config
. Consider removing the redundant re-import of ConfigDict (already imported on line 5) if it isn’t strictly needed. - Reason this comment was not posted:
Confidence changes required:10%
<= threshold50%
None
2. packages/traceloop-sdk/traceloop/sdk/version.py:1
- Draft comment:
Version bumped to 0.40.9 consistently across the SDK and instrumentation packages. Ensure the changelog accurately reflects this update. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
3. packages/opentelemetry-instrumentation-mistralai/pyproject.toml:14
- Draft comment:
Typo found: The repository URL contains 'openllmetry' which might be a misspelling of 'opentelemetry'. Please verify if this is intentional. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_nmHI5XvU7SuBSWIa
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samikshaaagarwal! Can you rebase and sign the CLA?
1bcf10b
to
2f60293
Compare
2f60293
to
95fdaf8
Compare
Hi @nirga , rebased the branch with the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @spullara! Mind reverting the changelog file and fixing the lint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert?
Fixes #2959
This PR replaces the deprecated use of
class Config
inRegistryObjectBaseModel
withmodel_config = ConfigDict(...)
, making the code compatible with Pydantic v2.Confirmed that the deprecation warning no longer appears after running tests.
Important
Replaced deprecated
class Config
withmodel_config = ConfigDict(...)
inRegistryObjectBaseModel
for Pydantic v2 compatibility and updated version to0.40.9
across multiple packages.class Config
withmodel_config = ConfigDict(...)
inRegistryObjectBaseModel
inmodel.py
for Pydantic v2 compatibility.class Config
for Pydantic v1 inmodel.py
.0.40.9
inpyproject.toml
andversion.py
across multiple packages includingalephalpha
,anthropic
,bedrock
,chromadb
,cohere
,crewai
,google-generativeai
,groq
,haystack
,lancedb
,langchain
,llamaindex
,marqo
,mcp
,milvus
,mistralai
,ollama
,openai
,pinecone
,qdrant
,replicate
,sagemaker
,together
,transformers
,vertexai
,watsonx
,weaviate
, andtraceloop-sdk
.This description was created by
for 1bcf10b. You can customize this summary. It will automatically update as commits are pushed.