Skip to content

Deprecated AirTable API Key detector #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kashifkhan0771
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 commented Jun 26, 2025

Description:

Airtable deprecated the API Keys on 1st Feb 2024.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@kashifkhan0771 kashifkhan0771 requested review from a team as code owners June 26, 2025 07:37
@kashifkhan0771
Copy link
Contributor Author

From Airtable docs:

On January 18th, 2023, we began the deprecation period of user API keys. That period has now ended. Since this was a major change to the Airtable API, the deprecation period lasted for 12 months and ended on Feb 1, 2024. This means that:

API Keys can no longer access the Airtable API.

Webhooks created with user API keys will not expire, but can no longer be created.

All users should migrate to Personal Access Tokens for individual use and OAuth for third-party integrations.

Ref: https://support.airtable.com/docs/creating-personal-access-tokens

@kashifkhan0771 kashifkhan0771 self-assigned this Jun 26, 2025
@@ -863,7 +862,7 @@ func buildDetectorList() []detectors.Detector {
&airbrakeprojectkey.Scanner{},
&airbrakeuserkey.Scanner{},
&airship.Scanner{},
&airtableapikey.Scanner{},
// &airtableapikey.Scanner{}, // AirTable depreacted the API Keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do not remove this from defaults but just comment out to keep track of old deprecated detectors as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was aware that detectors that are commented out in defaults.go have been disabled temporarily but not deleted or deprecated. I believe most deprecated detectors have been removed from the defaults.go file.
Since the detectors.proto file already keeps track of deprecated detectors, it should be safe to remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! I removed it from the engine defaults now

Copy link
Contributor

@amanfcp amanfcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants