-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Deprecated AirTable API Key detector #4266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Deprecated AirTable API Key detector #4266
Conversation
From Airtable docs:
Ref: https://support.airtable.com/docs/creating-personal-access-tokens |
pkg/engine/defaults/defaults.go
Outdated
@@ -863,7 +862,7 @@ func buildDetectorList() []detectors.Detector { | |||
&airbrakeprojectkey.Scanner{}, | |||
&airbrakeuserkey.Scanner{}, | |||
&airship.Scanner{}, | |||
&airtableapikey.Scanner{}, | |||
// &airtableapikey.Scanner{}, // AirTable depreacted the API Keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually do not remove this from defaults but just comment out to keep track of old deprecated detectors as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was aware that detectors that are commented out in defaults.go
have been disabled temporarily but not deleted or deprecated. I believe most deprecated detectors have been removed from the defaults.go
file.
Since the detectors.proto
file already keeps track of deprecated detectors, it should be safe to remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha! I removed it from the engine defaults now
2a12024
to
c8dc90d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Airtable deprecated the API Keys on 1st Feb 2024.
Checklist:
make test-community
)?make lint
this requires golangci-lint)?