Open
Description
I follow the codes in chapter 14 and find some little problems.
charClass_wordy
defined but not used, I think maybe thecharClass
function should be modified as following:
charClass (']':cs) = (']':) <$> globToRegex' cs
charClass (c:cs) = (c:) <$> charClass_wordy cs
-
According to monad fail, from GHC 8.8+, the
fail
function will not be supported. I suggest change thefail
function toerror
or other implementation. -
charClass_wordy also lacks a matching form, which should be added as follows:
charClassWordy "" =
error "No more input"
Metadata
Metadata
Assignees
Labels
No labels