fix(MVUX): Fix ablity to HR when adding/removing feed properties in model #2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the incremental hot-reload update for model feed properties by improving feed state transfer and caching in the BindableViewModelBase classes while updating tests and generated code accordingly.
- Change constructor access in BindableViewModelBase and add UnregisterDisposable
- Refactor feed property transfer logic with caching and logging improvements in HotReload support
- Update tests to include IAsyncDisposable and adjust generated view model code for improved initialization
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Uno.Extensions.Reactive/Presentation/Bindings/BindableViewModelBase.cs | Changed constructor access from public to protected and added an UnregisterDisposable method |
| src/Uno.Extensions.Reactive/Presentation/Bindings/BindableViewModelBase.HotReload.cs | Refactored feed transfer logic by introducing a property feeds cache and updating error/log handling |
| src/Uno.Extensions.Reactive/Core/Internal/StateStore.cs | Fixed minor comment typos |
| src/Uno.Extensions.Reactive.Tests/IntegrationTests/Given_HotReload.cs | Updated test models to implement IAsyncDisposable and added new hot-reload scenarios |
| src/Uno.Extensions.Reactive.Generator/Bindables/ViewModelGenTool_3.cs | Adjusted generated code with conditional compilation and improved model initialization |
Comments suppressed due to low confidence (1)
src/Uno.Extensions.Reactive/Presentation/Bindings/BindableViewModelBase.cs:43
- Changing the constructor access from public to protected prevents direct instantiation of BindableViewModelBase; please confirm that this design change is intentional.
protected BindableViewModelBase()
src/Uno.Extensions.Reactive/Presentation/Bindings/BindableViewModelBase.HotReload.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes unoplatform/studio#86
ugfix
Fix ablity to HR when adding/removing feed properties in model
What is the current behavior?
State is propagated only considering the original model properties
What is the new behavior?
State is propagated incrementally from each model, using a global cache of properties to ensure proper re-use / update
PR Checklist
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):