-
Notifications
You must be signed in to change notification settings - Fork 1.8k
docs(external): add docs for haversine
VRL function
#23336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I left you some feedback and suggestions for your review, mainly for clarity and consistency. Please re-request a review when ready.
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
#FunctionCategory: "Array" | "Codec" | "Coerce" | "Convert" | "Debug" | "Enrichment" | "Enumerate" | "Event" | "Path" | "Cryptography" | "IP" | "Number" | "Object" | "Parse" | "Random" | "String" | "System" | "Timestamp" | "Type" | "Checksum" | ||
|
||
// A helper array for generating docs. At some point, we should generate this from the | ||
// #FunctionCategory enum if CUE adds support for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't seem to be a way to generate an array from a disjunction, but there is a way to generate disjunction from an array, so I went with that route, to reduce duplication.
Summary
Adds docs for the new
haversine
VRL function.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changelog
label to this PR.References
haversine
function vrl#1442Notes
@vectordotdev/vector
to reach out to us regarding this PR.pre-push
hook, please see this template.cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)git merge origin master
andgit push
.Cargo.lock
), pleaserun
cargo vdev build licenses
to regenerate the license inventory and commit the changes (if any). More details here.