Use SourceBuffer timestampOffset
#7311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
enhancement/sourcebuffer-timestamp-offset
branch
from
814f85e to
aeb9214
Compare
5 tasks
…r than modify mp4 decode timestamps
robwalch
force-pushed
the
enhancement/sourcebuffer-timestamp-offset
branch
from
aeb9214 to
1f7a0f1
Compare
robwalch
force-pushed
the
enhancement/sourcebuffer-timestamp-offset
branch
from
09dd5f3 to
ceebdc9
Compare
robwalch
force-pushed
the
enhancement/sourcebuffer-timestamp-offset
branch
from
ceebdc9 to
794f5a0
Compare
robwalch
force-pushed
the
enhancement/sourcebuffer-timestamp-offset
branch
from
e7656be to
2dbc25a
Compare
3 tasks
…muxer when fmp4 starts with non-independent samples) Fixes #7312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Use SourceBuffer
timestampOffsetrather than modify mp4 decode timestamps.Why is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
This is a work-in-progress. Known issues include improper offset of discontinuities with MPEG-TS or muxed content. Additional testing and review is needed to find and fix the application of
initPTSoffsets on append.Resolves issues:
tfdtviapassthrough-remuxerandmp4-toolscan cause audible artifacting. #7310 (this is an issue with audio samples starting before video and the base media decode timestamp of audio of the first append being moved forward to 0 to avoid using a signed value for what is expected to be unsigned)Checklist