Fix unnecessary setting of MediaSource duration with stale value #7326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
robwalch
force-pushed
the
bugfix/prevent-mediasource-duration-ejection
branch
2 times, most recently
from
5376d38 to
e58a321
Compare
robwalch
force-pushed
the
bugfix/prevent-mediasource-duration-ejection
branch
from
e58a321 to
b28aa6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Wait to check if duration and seekable range should be set until any blocking operation is complete.
Why is this Pull Request needed?
Ensures that MediaSource duration is not set to a value less than its current value. Doing so invokes buffer ejection and can result in the next append failing because it puts the source in an updating state.
Are there any points in the code the reviewer needs to double check?
Branched from #7311, these changes should be rebased once that PR is merged.
Resolves issues:
Fixes #7321
Checklist