Add tracker support #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imsickofmaps please review |
| }; | ||
| return go.utils_project | ||
| .log_quiz_answer(self.im, quiz_question, choice.value, choice.label, | ||
| correct ? "True" : "False", response_text, self.im.user.answers.tracker) |
There was a problem hiding this comment.
this should just pass correct in directly. The JSON parser should handle it ok.
| @@ -1255,7 +1255,7 @@ return [ | |||
| "url": "http://localhost:8003/api/v1/tracker/cb245673-aa41-4302-ac47-t00000111111/", | |||
| "data": { | |||
| "complete": true, | |||
| "completed_at": "2016-04-04T22:00:00.000Z" | |||
There was a problem hiding this comment.
Sorry - what I meant was that it should include a timestamp that is not just "midnight UTC". You need a new go.utils.get_now() that actually returns an accurate hour/min/sec
There was a problem hiding this comment.
i added a get_now function to utils... not sure if we'd rather want it in utils_project..?
|
@imsickofmaps another review please |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend uses the concept of a
trackernow to keep answers grouped together. On start of a quiz session, it should be POSTed to with the identity uuid and the quiz: https://github.com/westerncapelabs/seed-continuous-learning/blob/develop/quizzes/tests.py#L255-L263In response you'll get a tracker UUID should you be provided with each answer log: https://github.com/westerncapelabs/seed-continuous-learning/blob/develop/quizzes/tests.py#L315-L326
Once completed, the tracker should be PATCHed to have a completed status: https://github.com/westerncapelabs/seed-continuous-learning/blob/develop/quizzes/tests.py#L291-L297