-
Notifications
You must be signed in to change notification settings - Fork 517
Easier option to enable a step operator/experiment tracker for a step #3774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great one but requires docs changes :-)! Maybe around here https://docs.zenml.io/concepts/steps_and_pipelines/configuration#direct-component-assignment
Yep didn't have time yesterday, I updated your page and also all the other ones I could find to use this simpler method. |
Documentation Link Check Results✅ Absolute links check passed |
ZenML CLI Performance Comparison (Threshold: 1.0s, Timeout: 60s, Slow: 5s)❌ Failed Commands on Current Branch (feature/easier-step-operator-configuration)
🚨 New Failures IntroducedThe following commands fail on your branch but worked on the target branch:
Performance Comparison
Summary
Environment Info
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, left a tiny comment.
@@ -145,8 +145,8 @@ class StepConfigurationUpdate(StrictBaseModel): | |||
enable_artifact_metadata: Optional[bool] = None | |||
enable_artifact_visualization: Optional[bool] = None | |||
enable_step_logs: Optional[bool] = None | |||
step_operator: Optional[str] = None | |||
experiment_tracker: Optional[str] = None | |||
step_operator: Optional[Union[bool, str]] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning to remove the str
option in the future?
If so, should we add a deprecation warning somewhere if people still use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, if we allow multiple instances of the same type of component in the future, it might make sense to keep the str
option as well.
Describe changes
This PR makes it easier to specify a step operator/experiment tracker for a step. Instead of requiring the name of the step operator/experiment tracker in the configuration (which is already implemented that way to facilitate multiple components of a type in a stack), this PR allows users to simply pass
step_operator=True
orexperiment_tracker=True
. The step operator/experiment tracker of the active stack will then be selected automatically.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes