Skip to content

feat(Raw:Img): ENG-9527 Added new inputs for raw:img to handle the metadata #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 30, 2025

Conversation

yash-builder
Copy link
Contributor

@yash-builder yash-builder commented Jun 18, 2025

Description

Previously, images imported from sources like Figma were treated as basic img tags and lacked the advanced editing capabilities of Builder's Image component (e.g., aspect ratio, overlays, etc.). This created an inconsistent user experience. This change ensures that all images, regardless of their source, can be fully customized within the editor.

Copy link

changeset-bot bot commented Jun 18, 2025

🦋 Changeset detected

Latest commit: ce4f9a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@builder.io/react Patch
@builder.io/sdk Patch
@builder.io/sdk-angular Patch
@builder.io/sdk-react-nextjs Patch
@builder.io/sdk-qwik Patch
@builder.io/sdk-react Patch
@builder.io/sdk-react-native Patch
@builder.io/sdk-solid Patch
@builder.io/sdk-svelte Patch
@builder.io/sdk-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Jun 18, 2025

View your CI Pipeline Execution ↗ for commit d31937f.

Command Status Duration Result
nx test @e2e/qwik-city ✅ Succeeded 10m 39s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 8m 53s View ↗
nx test @e2e/nuxt ✅ Succeeded 9m 14s View ↗
nx test @e2e/angular-17 ✅ Succeeded 8m 21s View ↗
nx test @e2e/react-sdk-next-15-app ✅ Succeeded 7m 15s View ↗
nx test @e2e/angular-19-ssr ✅ Succeeded 7m 17s View ↗
nx test @e2e/angular-17-ssr ✅ Succeeded 7m 10s View ↗
nx test @e2e/hydrogen ✅ Succeeded 6m 50s View ↗
Additional runs (37) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-30 03:37:15 UTC

@yash-builder yash-builder changed the title WIP! feat(Raw:Img): Added new inputs for raw:img to handle the metadata feat(Raw:Img): Added new inputs for raw:img to handle the metadata Jun 19, 2025
@yash-builder yash-builder self-assigned this Jun 19, 2025
@yash-builder yash-builder changed the title feat(Raw:Img): Added new inputs for raw:img to handle the metadata feat(Raw:Img): ENG-9527 Added new inputs for raw:img to handle the metadata Jun 19, 2025
@yash-builder yash-builder marked this pull request as ready for review June 19, 2025 08:40
@yash-builder yash-builder requested review from sidmohanty11 and a team June 19, 2025 08:41
Copy link
Contributor

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one last comment, LGTM

Copy link
Contributor

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's ask this in dev-cms first to confirm, if yes just re-export Image for Raw:Img

#4097 (comment)

@yash-builder
Copy link
Contributor Author

let's ask this in dev-cms first to confirm, if yes just re-export Image for Raw:Img

#4097 (comment)

(slack thread)

Copy link
Contributor

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments

Copy link
Contributor

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@yash-builder yash-builder merged commit 648653e into BuilderIO:main Jun 30, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants