Skip to content

fix[gen1][core]: ENG-9774 backported fix from v6.1.1 into v5 upgrade #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: ENG-9774-v5-current
Choose a base branch
from

Conversation

clyde-builderio
Copy link
Contributor

@clyde-builderio clyde-builderio commented Jun 26, 2025

For Manual upgrade only
Reference: #4102

JIRA Ticket:
https://builder-io.atlassian.net/browse/ENG-9800

Copy link

changeset-bot bot commented Jun 26, 2025

⚠️ No Changeset found

Latest commit: b142373

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented Jun 26, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14200383 Triggered Generic High Entropy Secret b142373 packages/core/src/builder.class.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@clyde-builderio
Copy link
Contributor Author

Closing to create a new PR

@clyde-builderio clyde-builderio changed the base branch from main to ENG-9774-v5-current June 26, 2025 09:18
@clyde-builderio clyde-builderio requested a review from a team as a code owner June 26, 2025 09:18
@clyde-builderio clyde-builderio requested review from samijaber and removed request for a team June 26, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant