Add EditorCommands menu #2058
Merged
Add EditorCommands menu #2058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `EditorInstance` to be able to move lines up and down
Bogdan-Belogurov
force-pushed
the
feat/lineUpAndDown
branch
from
9356d65 to
f94131a
Compare
|
Looks like this methods may need to be marked public |
|
@thecoolwinter Hi! Do you mean And I noticed an issue in the current solution. |
6 tasks
thecoolwinter
added a commit
to CodeEditApp/CodeEditSourceEditor
that referenced
this pull request
Jun 25, 2025
### Description Guarantees that all text coordinator's lifetimes match that of the editor's. ### Related Issues * CodeEditApp/CodeEdit#2058 ### Checklist - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code ### Screenshots
|
I'll be updating CE to use the latest version of CESE which will unblock this pr. I'll follow up after |
|
Merged the changes from main and this works now. Great stuff, and good catch on the coordinator lifecycle bug, |
thecoolwinter
approved these changes
Jul 7, 2025
austincondiff
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add EditorCommands menu and update
EditorInstanceto be able to move lines up and downRelated Issues
Checklist
Screenshots
Screen.Recording.2025-06-08.at.09.04.02.mov