New Feature Pagination #4704
Draft
New Feature Pagination #4704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinodkiran
requested review from
Copilot,
0xi4o and
HenryHengZJ
and removed request for
0xi4o
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2) ensure page limits are passed on load 3) co-pilot review comments (n+1 query) 4)
2) ensure page limits are passed on load 3) co-pilot review comments (n+1 query) 4) refresh lists after insert/delete.
There was a problem hiding this comment.
Pull Request Overview
Adds pagination support across list and table views by wiring a new TablePagination component through the UI, extending API client calls to accept page & limit parameters, and updating server-side controllers and services to handle paginated queries.
- Introduce a reusable
TablePaginationcomponent in the UI - Update list views to manage
currentPage,pageLimit,totaland call APIs with pagination - Extend client API methods, controllers, and services to accept and apply
page/limitparameters
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 2 comments.
Show a summary per file
| File Pattern | Description |
|---|---|
| packages/ui/src/views/*/index.jsx | Added pagination state/hooks and rendered <TablePagination> |
| packages/ui/src/ui-component/pagination/TablePagination.jsx | New reusable pagination component |
| packages/ui/src/api/*.js | Updated getAll* endpoints to accept { params: { page, limit } } |
| packages/server/src/utils/pagination.ts | New utility to parse page and limit from req.query |
| packages/server/src/services/*/index.ts | Updated services to apply .skip()/.take() when page>0 & limit>0 |
| packages/server/src/controllers/*/index.ts | Controllers now call services with parsed page and limit |
| packages/ui/src/ui-component/table/DocumentStoreTable.jsx | New table component for document store view |
Comments suppressed due to low confidence (1)
packages/ui/src/views/variables/index.jsx:343
- Filtering the variable list client-side after pagination limits results to the current page only, so search won’t find matches on other pages. Consider passing the search query to the API so filtering happens server-side before pagination.
{variables.filter(filterVariables).map((variable, index) => (
… API key services - Added check for empty entities in DocumentStoreDTO.fromEntities to return an empty array. - Updated condition in getAllDocumentStores to handle total count correctly, allowing for zero total. - Refined logic in getAllApiKeys to check for empty keys and ensure correct API key retrieval. - Adjusted UI components to safely handle potential undefined apiKeys array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Pagination Support (Table view and Card view) for the following
The following will NOT be taken up in this PR and will be handled separately shortly.