Closed
Description
Have you considered including more of the standard output of npm's "dry run" mode? I find that quite helpful sometimes, such as to see what all files would be included in the published package (so that I can adjust things to remove unneeded files).
Here's a slightly-redacted example of what npm shows:
npm notice 📦 @some-org/some-package@1.2.3
npm notice === Tarball Contents ===
npm notice 1.1kB LICENSE
npm notice 2.6kB README.md
npm notice 20.3kB dist/index.js
npm notice 17.8kB dist/index.mjs
npm notice 1.4kB package.json
npm notice 3.1kB src/SomeFile.svelte
npm notice 72B src/index.js
npm notice 1.8kB src/loader.js
...
However, the npm-publish GitHub action seems to only show something like this:
Run JS-DevTools/npm-publish@v3
with:
token: ***
dry-run: true
🙅♀️ @some-org/some-package@1.2.3 publish skipped.
Thank for making helpful open source packages, nonetheless! 😁
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Participants
Activity
mcous commentedon Mar 20, 2024
I like this idea! I think what might be happening here is that
dry-rundoesn't affect the version check logic, so if you're in dry-run mode but the version in question is already released,npm publish --dry-runwill never be called.What we could do is have
dry-runproceed past the version check (with appropriate logging) and runnpm publish --dry-runno matter what. I think if we do that, we'll get the nice little pack logforevermatt commentedon Mar 20, 2024
Sounds promising, thanks! Unfortunately, I'm not familiar enough with this codebase to submit a PR myself. Sorry. 😞
mcous commentedon Mar 20, 2024
All good! It’ll be a pretty small lift if my assumptions hold 🤞, will take a crack at it by Friday
forevermatt commentedon Mar 25, 2024
Awesome, thanks! We're already seeing those changes in our builds, and it looks great! 😁 🎉