Fix error: template-id not allowed for constructor and some Doxygen errors #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building ola fails on Fedora with GCC-14:
In file included from ./include/ola/Clock.h:32:
./include/ola/base/Macro.h:45:11: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
45 | TypeName(const TypeName&); \
| ^
./include/ola/thread/FuturePrivate.h:92:3: note: in expansion of macro 'DISALLOW_COPY_AND_ASSIGN'
92 | DISALLOW_COPY_AND_ASSIGN(FutureImpl<T>);
| ^~~~~~~~~~~~~~~~~~~~~~~~
./include/ola/base/Macro.h:45:11: note: remove the '< >'
45 | TypeName(const TypeName&); \
| ^
When a class already is templatified, the templification can't be
repeated on contained methods.
(cherry picked from commit d9b9c78)
peternewman
changed the title
|
@peternewman may you please take at the other C++20 related PRs as well (#1889, #1890, #1989, possibly #1975)? Thanks! |
peternewman
changed the title
Thanks @DaAwesomeP . I'd like to address the general C++20 etcetera PRs via making a decision in #2005 first, I just pulled this bit in, as I noticed we'd had the same issue in the two newest CI builds and it doesn't upset the older stuff. |
|
Removing the retrospective and the review request given #2013 essentially mirrors this and got reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.