fix(eslint-plugin): detect node API usage more accurately #7664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build/v2
🦋 Changeset detectedLatest commit: 3e304c3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
reviewed
Jun 24, 2025
packages/eslint-plugin-qwik/tests/scope-use-task/valid-scope-use-return-object.tsx
Outdated
Show resolved
Hide resolved
wmertens
changed the title
wmertens
requested changes
Jun 24, 2025
…prove edge case handling
…efault forbidden APIs
wmertens
requested changes
Jul 5, 2025
Comment on lines
+160
to
+162
| // If we didn't find a variable, it might be a global API or an undeclared variable. | ||
| if (!GLOBALAPIS.includes(identifierNode.name)) { | ||
| return true; |
There was a problem hiding this comment.
this seems wrong? It will almost always be true, and if it is correct then it should be befor the while loop because it's not using the result of the while loop
| } | ||
|
|
||
| if (variable.defs.length === 0) { | ||
| if (variable?.defs.length === 0) { |
There was a problem hiding this comment.
because you removed the !variable test, now you needed to add this. Just add the !varaible test again
| export default component$(() => { | ||
| function child_process() {} |
There was a problem hiding this comment.
this is valid code, because it shadows the global child_process, and shouldn't fail the eslint test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
I enhanced the
qwik-eslint-pluginto support two edge cases:initin aVariableDeclaratorin AST.2.When path is used as a property key inside an object.
adding two situations
Checklist
pnpm change