Skip to content

Consider non-timeseries parameters to be ContinuousTimeseries #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChrisRackauckas
Copy link
Member

This does a few things. First of all it fixes SciML/SciMLBase.jl#1061 by making parameters plot as lines. But secondly, it treats parameters the same way as variables, which is a requirement if we want to make it simpler for the compiler to change things from the state to parameters.

This does a few things. First of all it fixes SciML/SciMLBase.jl#1061 by making parameters plot as lines. But secondly, it treats parameters the same way as variables, which is a requirement if we want to make it simpler for the compiler to change things from the state to parameters.
Copy link
Contributor

github-actions bot commented Jul 5, 2025

Benchmark Results (Julia vlts)

Time benchmarks
master 7905b6a... master / 7905b6a...
ODEProblem 0.0827 ± 0.0068 s 0.0835 ± 0.0059 s 0.991 ± 0.11
init 0.0621 ± 0.0021 ms 0.0599 ± 0.0016 ms 1.04 ± 0.045
large_parameter_init/ODEProblem 0.701 ± 0.0098 s 0.733 ± 0.023 s 0.957 ± 0.033
large_parameter_init/init 0.111 ± 0.0024 ms 0.11 ± 0.0021 ms 1.01 ± 0.029
mtkcompile 0.0346 ± 0.00076 s 0.0344 ± 0.0016 s 1.01 ± 0.052
time_to_load 5.56 ± 0.029 s 5.53 ± 0.026 s 1.01 ± 0.007
Memory benchmarks
master 7905b6a... master / 7905b6a...
ODEProblem 0.59 M allocs: 20.1 MB 0.591 M allocs: 20.1 MB 0.998
init 0.908 k allocs: 0.0479 MB 0.908 k allocs: 0.0479 MB 1
large_parameter_init/ODEProblem 4.58 M allocs: 0.176 GB 4.61 M allocs: 0.177 GB 0.991
large_parameter_init/init 1.75 k allocs: 0.0874 MB 1.75 k allocs: 0.0874 MB 1
mtkcompile 0.233 M allocs: 8.68 MB 0.233 M allocs: 8.68 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Contributor

github-actions bot commented Jul 5, 2025

Benchmark Results (Julia v1)

Time benchmarks
master 7905b6a... master / 7905b6a...
ODEProblem 0.0796 ± 0.006 s 0.0812 ± 0.0057 s 0.981 ± 0.1
init 0.0558 ± 0.012 ms 0.049 ± 0.012 ms 1.14 ± 0.38
large_parameter_init/ODEProblem 0.731 ± 0.046 s 0.729 ± 0.04 s 1 ± 0.084
large_parameter_init/init 0.0976 ± 0.012 ms 0.0977 ± 0.012 ms 0.999 ± 0.18
mtkcompile 0.033 ± 0.00039 s 0.0338 ± 0.00038 s 0.974 ± 0.016
time_to_load 5.38 ± 0.0065 s 5.38 ± 0.034 s 1 ± 0.0064
Memory benchmarks
master 7905b6a... master / 7905b6a...
ODEProblem 0.58 M allocs: 18.9 MB 0.58 M allocs: 18.9 MB 1
init 0.818 k allocs: 0.0319 MB 0.818 k allocs: 0.0319 MB 1
large_parameter_init/ODEProblem 4.65 M allocs: 0.168 GB 4.66 M allocs: 0.168 GB 0.997
large_parameter_init/init 1.66 k allocs: 0.0712 MB 1.66 k allocs: 0.0712 MB 1
mtkcompile 0.233 M allocs: 8.09 MB 0.233 M allocs: 8.08 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to plot parameters
1 participant