Modify NPM importer to support package-first mode #1941
+356
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update NPM importer to filter and process advisories relevant to the purl passed in the constructor * Update NPM v2 importer to filter and process advisories relevant to the purl passed in the constructor * Update NPM importer tests to test package-first mode * Update NPM v2 importer tests to test package-first mode Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
…1936 Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
michaelehab
requested review from
TG1999 and
keshav-space
and removed request for
TG1999
TG1999
reviewed
Jul 15, 2025
| @classmethod | ||
| def steps(cls): | ||
| return ( | ||
| return [ |
TG1999
reviewed
Jul 15, 2025
| advisory_files = filtered_files | ||
|
|
||
| for advisory in list(advisory_files): | ||
| for result in self.to_advisory_data(advisory): |
There was a problem hiding this comment.
Why we are not using yield from here ?
TG1999
reviewed
Jul 15, 2025
| advisory_files = list(vuln_directory.glob("*.json")) | ||
|
|
||
| if not self.is_batch_run: | ||
| package_name = self.purl.name |
There was a problem hiding this comment.
Why we not actually check in our DB if the purl exists, before even checking all files ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1936