Add job_workflow_ref label to listener metrics

[rskmm0chang]

fix: #4053

[Copilot]

Pull Request Overview

This PR adds a new label for job workflow references to the listener metrics to address issue #4053 by extending the metric dimensions.

• Added a constant for "job_workflow_ref".
• Updated the exporter to include the job_workflow_ref from jobBase.

Comments suppressed due to low confidence (1)

cmd/ghalistener/metrics/metrics.go:83

• Consider adding test coverage to validate that the job_workflow_ref label is correctly mapped in the metrics exporter.

labelKeyJobWorkflowRef: jobBase.JobWorkflowRef,

[rskmm0chang]

@nikola-jokic

Hi, thank you always for your great maintenance work.
Regarding the job_workflow_ref label that was removed in v0.11.0, we actively use it in our operations for ARC.
I've created a pull request for this. Please let me know if there are any considerations I've missed or if you have any comments.

[nikola-jokic]

Hey @rskmm0chang,

Thank you for your kind words! Can you please add the configurable part as well, including these metrics in values.yaml?

[rskmm0chang]

@nikola-jokic

Thank you for your comment.
I added it at https://github.com/actions/actions-runner-controller/pull/4054/files#diff-dc582b4dc873f100695b98727c859d0c547ea228b6f09f206857f5c5d64dd8a9. Are there any other places where this is required?

[nikola-jokic]

Hey @rskmm0chang,

It seems to me that gha_started_jobs_total and gha_completed_jobs_total also used to have the the job_workflow_ref label, so could you please include it in the values.yaml?

[rskmm0chang]

@nikola-jokic

Hi, thank you for your comments!

I updated values.yaml at 4159865

[nikola-jokic]

LGTM! Thank you for your contribution!

[pedrolarios]

Hi @nikola-jokic, do I need to update my helm release to get the fix?

[nikola-jokic]

Hey @pedrolarios,

You need to wait for the next release, which is coming up next week.