-
Notifications
You must be signed in to change notification settings - Fork 129
Spelling #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Spelling #921
Conversation
@@ -233,7 +233,7 @@ jobs: | |||
fail-on-severity: critical | |||
deny-licenses: LGPL-2.0, BSD-2-Clause | |||
comment-summary-in-pr: always | |||
allow-dependencies-licenses: 'pkg:npm/loadash, pkg:pypi/requests' | |||
allow-dependencies-licenses: 'pkg:npm/lodash, pkg:pypi/requests' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was odd...
afaict, loadash
isn't a package real people are supposed to use:
https://www.npmjs.com/package/loadash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catches, thanks for the PR! It's odd how there were two occurrences of summmary
with three m
s!
I need to figure out how to deal with the merge conflict in the generated index.js.map file; I can't just merge it manually from the CLI due to branch protection rules (everything needs to be a PR). |
@ahpook: I can drop the changes to those files if that helps. |
@jsoref I think you'll need to merge the main branch into your branch and then run |
@ahpook: would it be easier if I didn't include changes to these files and you either pushed a change when you were ready to merge or merged and then pushed the change? Chasing updates to this is not a particularly good use of my time. |
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/dependency-review-action/actions/runs/14482795446#summary-40622858457
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/dependency-review-action/actions/runs/14482795515#summary-40622858504