Skip to content

Spelling #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Spelling #921

wants to merge 8 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 16, 2025

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/dependency-review-action/actions/runs/14482795446#summary-40622858457

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/dependency-review-action/actions/runs/14482795515#summary-40622858504

@jsoref jsoref requested a review from a team as a code owner April 16, 2025 01:36
@@ -233,7 +233,7 @@ jobs:
fail-on-severity: critical
deny-licenses: LGPL-2.0, BSD-2-Clause
comment-summary-in-pr: always
allow-dependencies-licenses: 'pkg:npm/loadash, pkg:pypi/requests'
allow-dependencies-licenses: 'pkg:npm/lodash, pkg:pypi/requests'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was odd...

afaict, loadash isn't a package real people are supposed to use:
https://www.npmjs.com/package/loadash

ahpook
ahpook previously approved these changes Apr 18, 2025
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, thanks for the PR! It's odd how there were two occurrences of summmary with three ms!

@ahpook
Copy link
Contributor

ahpook commented Apr 18, 2025

I need to figure out how to deal with the merge conflict in the generated index.js.map file; I can't just merge it manually from the CLI due to branch protection rules (everything needs to be a PR).

@jsoref
Copy link
Contributor Author

jsoref commented Apr 20, 2025

@ahpook: I can drop the changes to those files if that helps.

@dangoor
Copy link
Contributor

dangoor commented May 5, 2025

@jsoref I think you'll need to merge the main branch into your branch and then run npm run build to create updated dist/* files. You can basically ignore the conflicts when merging into your branch, since you'll be rebuilding the files anyway.

@jsoref
Copy link
Contributor Author

jsoref commented May 8, 2025

@ahpook: would it be easier if I didn't include changes to these files and you either pushed a change when you were ready to merge or merged and then pushed the change? Chasing updates to this is not a particularly good use of my time.

jsoref added 8 commits May 8, 2025 17:20
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants