Bug: Mask fwupd timer on ubuntu images
#12225
Conversation
We're running on VMs in Azure and the fwupd package is not needed. Leaving it enable means periodic refreshes show in network traffic and firewall logs.
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the fwupd package is uninstalled from Ubuntu VM images and adds a test to verify its removal.
- Added a Pester test to assert that
fwupdis not present on the box. - Updated the environment setup script to purge
fwupdif installed and disable any remaining timer/config.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| images/ubuntu/scripts/tests/System.Tests.ps1 | Added a test block to verify fwupd is removed |
| images/ubuntu/scripts/build/configure-environment.sh | Purges fwupd package and disables its timer/config |
lawrencegripper
changed the title
fwupd from ubuntu imagesfwupd timer on ubuntu images
|
@subir0071 I think this failed CI on Ubuntu 22.04 I see:
Build: 24.04 was fine 🟢 |
* Bug: Fully remove `fwupd` from ubuntu images We're running on VMs in Azure and the fwupd package is not needed. Leaving it enable means periodic refreshes show in network traffic and firewall logs. * Update check method * Simplify test
* Bug: Fully remove `fwupd` from ubuntu images We're running on VMs in Azure and the fwupd package is not needed. Leaving it enable means periodic refreshes show in network traffic and firewall logs. * Update check method * Simplify test Co-authored-by: Lawrence Gripper <lawrencegripper@github.com>
We're running on VMs in Azure and the fwupd package is not needed.
Leaving it enable means periodic refreshes show in network traffic and firewall logs.
The current check has a bug, meaning the timer isn't masked.
In the current
fwupdversion there isn't adaemon.conffile present so theifcondition doesn't run and doesn't mask the systemd unit.Related issue:
Check list