[macOS]Add Mozila Firfox to macOS 13,14 and 15 arm64 images. #12226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sureshe456! Please move the Firefox script right next to the Google Chrome installer in the templates and I'll be okay with the PR. Example: ...
"${path.root}/../scripts/build/install-chrome.sh",
"${path.root}/../scripts/build/install-edge.sh",
"${path.root}/../scripts/build/install-firefox.sh",
"${path.root}/../scripts/build/install-bicep.sh",
"${path.root}/../scripts/build/install-codeql-bundle.sh"
]
... |
There was a problem hiding this comment.
Pull Request Overview
Add Mozilla Firefox to the macOS 13, 14, and 15 ARM64 images and enable its presence test.
- Include
install-firefox.shin the Packer build steps for all targeted macOS templates. - Remove the skip condition so Firefox is verified in
Browsers.Tests.ps1.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| images/macos/templates/macOS-15.arm64.anka.pkr.hcl | Added install-firefox.sh to the build array |
| images/macos/templates/macOS-14.arm64.anka.pkr.hcl | Added install-firefox.sh to the build array |
| images/macos/templates/macOS-13.arm64.anka.pkr.hcl | Added install-firefox.sh to the build array |
| images/macos/scripts/tests/Browsers.Tests.ps1 | Removed skip condition to test Firefox presence |
Comments suppressed due to low confidence (2)
images/macos/scripts/tests/Browsers.Tests.ps1:56
- [nitpick] Consider making the test description more descriptive—e.g.,
Describe 'Firefox installation'—to clarify that this block checks for the browser's presence.
Describe "Firefox" {
images/macos/templates/macOS-15.arm64.anka.pkr.hcl:251
- Ensure that the
install-firefox.shscript is committed underimages/macos/scripts/buildand marked executable; otherwise the Packer build will fail when it tries to invoke this step.
"${path.root}/../scripts/build/install-firefox.sh"
|
Hi @erik-bershel Moved the firefox script next to chrome installer as your requested.Thanks. |
erik-bershel
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.Add Mozila Firfox to macOS 13,14 and 15 arm64 images.
2. User raised public issue 12049
Related issue:
Check list