Handle relative paths starting with hyphens in io's rmRF #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `io.rmRF` with a relative path to a directory that starts with a hyphen on non-Windows systems, the directory name was interpreted as an option to `rm`. Fix that by separating options and arguments via a double-hyphen `--`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
io.rmRFwith a relative path to a directory that starts with a hyphen on non-Windows systems, the directory name was interpreted as an option torm. Fix that by separating options and arguments via a double-hyphen--.Without this change, the provided test fails with: