feat: decoupled prometheus exporter's calculation and output #12383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heus-exporter-concurrency
SkyeYoung
commented
Jun 27, 2025
| {name = "waiting", var = "ngx_stat_waiting"}, | ||
| } | ||
|
|
||
| -- Use FFI to get nginx status directly from global variables | ||
| local function nginx_status() |
There was a problem hiding this comment.
Because API disabled in the context of ngx.timer, context: ngx.timer.
Here use FFI to rewrite the nginx_status logic.
| OLD(master) | NEW(current) |
|---|---|
 |
 |
There was a problem hiding this comment.
Underhood: The ngx.var is related to the request context, which is inaccessible; nginx subrequests are also not available. Hence the rewrite to FFI.
SkyeYoung
commented
Jun 27, 2025
| @@ -454,10 +458,11 @@ local function collect(ctx, stream_only) | |||
| local config = core.config.new() | |||
|
|
|||
| -- config server status | |||
| local vars = ngx.var or {} | |||
| local hostname = vars.hostname or "" | |||
| local hostname = core.utils.gethostname() or "" | |||
There was a problem hiding this comment.
Because API disabled in the context of ngx.timer, context: ngx.timer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Which issue(s) this PR fixes:
Fixes #
Checklist