Skip to content
This repository was archived by the owner on Sep 24, 2025. It is now read-only.

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented May 4, 2024

See parent issue for details.

This PR:

  • Sets a 1 hour timeout for an Apply request to complete.
    • (I'm definitely open to other values here, but my expectation is users would only expect an apply to be active for seconds, or at most a single digit number of minutes).
    • For contrast, the timeout for replace (when force=true) is 5 minutes

Why no timeout for create operation? Not supported by kubectl code, AFAICT. Why no timeout for replace? Not supported by kubectl code, except in the case where force is true, in which case the timeout is 5 minutes.

Fixes #572

Signed-off-by: Jonathan West <jonwest@redhat.com>
Copy link

sonarqubecloud bot commented May 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgwest jgwest marked this pull request as ready for review May 6, 2024 10:42
@ppapapetrou76
Copy link
Contributor

The gitops-engine repository is migrating to https://github.com/argoproj/argo-cd. We are closing all draft PRs.
Please feel free to submit it again once the migration is over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Apply/ReplaceResource' in resource_ops.go may leak files to '/dev/shm' since the kubectl 'apply/replace' commands never time out
2 participants