[Bug]: missing build dep python3-pygments

[amazingfate]

What happened?

Wrote 194 lines to /home/jfliu/dev/armbian/build/cache/sources/linux-kernel-worktree/6.12__rockchip64__arm64/arch/arm64/boot/dts/rockchip/Makefile
   Summary: kernel patching: 187 total patches; 187 applied; 25 with problems; 24 needs_rebase; 1 not_mbox; 1 invalid_diff
   Traceback (most recent call last):
     File "/home/jfliu/dev/armbian/build/lib/tools/patching.py", line 444, in <module>
       from rich.syntax import Syntax
     File "/home/jfliu/dev/armbian/build/cache/pip/base/lib/python3.12/site-packages/rich/syntax.py", line 21, in <module>
       from pygments.lexer import Lexer
   ModuleNotFoundError: No module named 'pygments'
--> (167) ERROR: Error 1 occurred in main shell [ at /home/jfliu/dev/armbian/build/lib/functions/logging/runners.sh:211
       run_host_command_logged_raw() --> lib/functions/logging/runners.sh:211
           run_host_command_logged() --> lib/functions/logging/runners.sh:193
       kernel_main_patching_python() --> lib/functions/compilation/kernel-patching.sh:64
                     do_with_hooks() --> lib/functions/general/extensions.sh:567
                   do_with_logging() --> lib/functions/logging/section-logging.sh:81
              kernel_main_patching() --> lib/functions/compilation/kernel-patching.sh:79
                    compile_kernel() --> lib/functions/compilation/kernel.sh:54
      artifact_kernel_build_from_sources() --> lib/functions/artifacts/artifact-kernel.sh:240
       artifact_build_from_sources() --> lib/functions/artifacts/artifacts-obtain.sh:34
          obtain_complete_artifact() --> lib/functions/artifacts/artifacts-obtain.sh:280
             do_with_default_build() --> lib/functions/main/default-build.sh:42
                  cli_artifact_run() --> lib/functions/cli/cli-artifact.sh:70
           armbian_cli_run_command() --> lib/functions/cli/utils-cli.sh:136
                    cli_entrypoint() --> lib/functions/cli/entrypoint.sh:176
                              main() --> compile.sh:50
    ]
   -->--> command failed with error code 1 after 7 seconds

How to reproduce?

PREFER_DOCKER=no ./compile.sh kernel-dtb BOARD=rock-5b BRANCH=current

Branch

main (main development branch)

On which host OS are you running the build script and observing this problem?

Ubuntu 24.04 Noble

Are you building on Windows WSL2?

• Yes, my Ubuntu/Debian/OtherOS is running on WSL2

Relevant log URL

https://paste.armbian.eu/ifusuxucid

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Jira ticket: AR-2626

[rpardini]

Hey @amazingfate, help me out here. From your logs it seems to me:

• this was the first run of compile.sh on a machine, without Docker. (this is because uuid-runtime was installed during basic reqs, line 44, and prepare-host installed a bunch of hostdeps, line 143)
• but somehow, the git bare tree (shallow) already existed... (line 444)
• also the Python dependencies also were already cached (line 596)

I am wondering if you copied over or transferred a disk that already had caches to a new OS install?

Either way, I've recently changed to use only the very basic python bin and lib from the OS, and install everything else (even pip itself) from scratch. Rich should depend on Pygments, and pip should resolve that. In the end, it's almost like we have a full venv for all the armbian/build Python stuff (despite not really using venv).

The only part that I can imagine can be failing here is the "hashing"/"caching" I do (based on the requirements.txt contents, which does not include transitive dependencies) to avoid calling pip every time (which is slow even if all deps are already met). If that's the case I could try and add more factors to the cache, such as machine_id or such to try and avoid this bug.

Let me know...
Ricardo

[amazingfate]

Yes you're right. I accidentally cleaned my root partition on emmc but I have my home partition mounted at a nvme ssd. So this is the first time running armbian build script after reflashing armbian to emmc with all cached source code.

[rpardini]

Clear. To cover this case I will try to hash systemd's machine-id and some more python version details, so if the machine or python changes, pip install is re-run and dependencies should be put correctly in place.

What still puzzles me if how Pygments came to be missing, since Rich is installed, but I guess at this point it's not that important.