docs: fix inconsistencies in snippets #192
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix autoscrape-labs#191 - intercepting requests is a browser feature and this pr fixes cases where tab was used instead of browser for enabling fetch events and callbacks
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
For changes, please see L174 in docs/deep-dive/event-system.md and around L888 in docs/features.md. The remaining is noise produced by my markdown settings. |
|
No problem, that looks great! Thank you. |
thalissonvs
approved these changes
Jul 10, 2025
thalissonvs
requested changes
Jul 10, 2025
Comment on lines
-900
to
+901
| await tab.enable_request_interception() | ||
| await tab.on('Fetch.requestPaused', block_unwanted_requests) | ||
|
|
||
| await browser.enable_fetch_events() | ||
| await browser.on('Fetch.requestPaused', block_unwanted_requests) |
There was a problem hiding this comment.
actually, i fixed this bug, it will be in the next release
There was a problem hiding this comment.
oh nice. enabling fetch events for a tab?
There was a problem hiding this comment.
yes, exactly. You can keep as it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_all=True#191fixes cases where tab was used instead of browser for enabling fetch
events and callbacks
Pull Request
Description
Related Issue(s)
Type of Change
How Has This Been Tested?
# Include code examples if relevantTesting Checklist
Screenshots
Implementation Details
API Changes
Additional Info
Checklist before requesting a review
poetry run task lintand fixed any issuespoetry run task testand all tests pass