Skip to content

Remove unnecessary NETWORK_ENV variable from docker-compose.yml #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GarmashAlex
Copy link

Replaced the use of the NETWORK_ENV environment variable with a direct reference to .env.mainnet in the env_file section for both services. This simplifies the configuration and removes unnecessary indirection. To switch networks, manually change the env_file as needed.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout
Copy link
Collaborator

@GarmashAlex is the extra env causing any issues? Happy to remove if so, but it's handy to be able to toggle this via a .env file IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants