Remove unnecessary NETWORK_ENV variable from docker-compose.yml #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
|
@GarmashAlex is the extra env causing any issues? Happy to remove if so, but it's handy to be able to toggle this via a .env file IMO |
|
Closing this for now. If it's causing an issue let me know and we can discuss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the use of the NETWORK_ENV environment variable with a direct reference to .env.mainnet in the env_file section for both services. This simplifies the configuration and removes unnecessary indirection. To switch networks, manually change the env_file as needed.