Skip to content

[PM-23094] Replace Thread.Sleep with Task.Delay #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justindbaur
Copy link
Member

@justindbaur justindbaur commented Jun 26, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23094

📔 Objective

Allow the thread to be reused elsewhere while waiting for the jobs to get successfully scheduled.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details8ecbcf02-e101-4843-a700-44f475784ff8

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.72%. Comparing base (71aae24) to head (048f12e).

Files with missing lines Patch % Lines
src/Core/Jobs/BaseJobsHostedService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6006   +/-   ##
=======================================
  Coverage   47.72%   47.72%           
=======================================
  Files        1692     1692           
  Lines       74972    74972           
  Branches     6758     6758           
=======================================
  Hits        35777    35777           
  Misses      37739    37739           
  Partials     1456     1456           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trmartin4 trmartin4 changed the title Replace Thread.Sleep with Task.Delay [PM-23094] Replace Thread.Sleep with Task.Delay Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant