Filter out dropped clients in the send worker #2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Jun 25, 2025
gefjon
reviewed
Jun 26, 2025
joshua-spacetime
force-pushed
the
joshua/perf/client-filter
branch
from
ee7a802 to
1fb4f60
Compare
gefjon
approved these changes
Jun 28, 2025
joshua-spacetime
added a commit
that referenced
this pull request
Jul 1, 2025
joshua-spacetime
added a commit
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Moves the filtering out of dropped clients during subscription evaluation from inside of
eval_updates_sequential, where we hold the transaction lock, to the send worker, where the lock has been released.API and ABI breaking changes
None
Expected complexity level and risk
0
Testing