check if container already created #1251
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc-sheet
force-pushed
the
check-deps
branch
2 times, most recently
from
1fa5461 to
ddba1da
Compare
p12tic
reviewed
Jun 27, 2025
|
|
||
| if args.force_recreate or cnt["name"] not in created_containers: | ||
| podman_args = await container_to_args( | ||
| compose, cnt, detached=False, no_deps=args.no_deps |
There was a problem hiding this comment.
Shouldn't we also check for running containers and not start these?
There was a problem hiding this comment.
I checked - podman start for already started container just exits with rc 0 so I skipped extra validation.
There was a problem hiding this comment.
Thanks. I think it makes sense to add an explanatory comment near the call to podman start then.
p12tic
requested changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC for #1118