-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: update stop button to immediately update UI in headed no-exit mode #31991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
{"message":"An internal server error occurred."} |
@@ -1939,9 +1939,11 @@ export default { | |||
|
|||
_runner.stopped = true | |||
|
|||
// if we are in open mode, abort the run immediately | |||
const isHeadedNoExit = Cypress.config('browser').isHeaded && !Cypress.config('exit') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe exit
is stored in Cypress.config
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It exists in the above code:
cypress/packages/driver/src/cypress/runner.ts
Line 529 in 82e0598
const isHeadedNoExit = Cypress.config('browser').isHeaded && !Cypress.config('exit') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately, that's probably wrong too then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it detects isHeadedNoExit
correctly, I tested the change myself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is Cypress.config('exit')
returns undefined
so that expression evaluates to true
. But if you don't pass in --no-exit
that would also evaluate to true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the type for Cypress.config('exit')
seems to exist, no type error within that file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typing hasn't been fully completed in runner.ts
yet so Cypress
is any
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mschile YEP, isHeadedNoExit
gives true in both cases
line 529 should be investigated #31991 (comment)
Amends #31984 for
--headed --no-exit
mode