remove undocumented top-level "docker remove" command #6144
+13
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker container remove
as an alias #3986docker container remove
anddocker container copy
do not exist, whiledocker (image|volume|network) remove
exist #3985This was introduced in 9b54d86, which added
docker container remove
as alias fordocker container rm
.However, due to the
NewRmCommand
being used both for adding the top-leveldocker rm
command and for adding thedocker container rm
command, it also introduced a (hidden) top-leveldocker remove
command;The command was not documented, and did not appear in
--help
output, nor was auto-complete provided;This patch adds a dedicated, non-exported
newRemoveCommand
to add sub- commands fordocker container
, taking a similar approach as was done in moby@b993609d5a fordocker image rm
.With this patch applied, the hidden command is no longer there, but the
docker rm
,docker container rm
, anddocker container remove
commands stay functional as intended;Reported-by: Lorenzo Buero 138243046+LorenzoBuero@users.noreply.github.com
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)