Remove src/Compatibility folder and obsolete legacy code #30228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
Copilot finished work on behalf of
mattleibow
June 25, 2025 23:06
mattleibow
force-pushed
the
copilot/fix-30227
branch
from
794cd52 to
cc164a8
Compare
|
There is a Microsoft.Maui.Controls.Hosting.CompatibilityCheck.UseCompatibility that will exist in the Controls code, but can never run since there is no way to enable it. https://github.com/search?q=repo%3Adotnet%2Fmaui%20CompatibilityCheck&type=code It was used here: 
|
Copilot finished work on behalf of
mattleibow
June 26, 2025 00:21
|
Is this PR supposed to target |
|
net10.0 but ai only works on main. So hopefully I can just rebase or something. |
|
/azp run MAUI-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-DeviceTests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
This PR removes the entire
src/Compatibilityfolder containing obsolete legacy code that is no longer built or tested, as requested in the issue.What was removed
The following obsolete projects and code were completely removed:
Essential files preserved
Before removal, essential resource files that were still being used by the main codebase were migrated to appropriate locations:
flyoutcontent.axmlandshellcontent.axmlfromsrc/Compatibility/Core/src/Android/Resources/layout/tosrc/Controls/src/Core/Platforms/Android/Resources/layout/StringResources.*files fromsrc/Compatibility/Core/src/iOS/Resources/tosrc/Controls/src/Core/Platforms/iOS/Resources/Additional cleanup
.sln,.slnf)InternalsVisibleToattributes referencing removed Compatibility assembliesusingstatements for Compatibility namespacesVerification
Controls.CoreandCore.UnitTestsprojects build successfully after all changesThis cleanup removes a significant amount of obsolete code (~2,700+ files) while preserving all essential functionality currently in use.
Fixes #30227.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.