STJ: Adding support for JsonNamingPolicyAttribute #117079
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
|
cc: @eiriktsarpalis maybe you could take a quick look if the direction is right |
I don't think that would be necessary, the final computed name should simply be reflected in the |
| @@ -52,14 +52,14 @@ | |||
| <Project Path="tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj" /> | |||
| </Folder> | |||
| <Folder Name="/tools/" /> | |||
| <Folder Name="/tools/gen/"> | |||
| <Folder Name="/tools/gen/" Id="5ad0b2ae-1660-5889-7060-a20f14d475b9"> | |||
| JsonKnownNamingPolicy.SnakeCaseLower => JsonNamingPolicy.SnakeCaseLower, | ||
| JsonKnownNamingPolicy.SnakeCaseUpper => JsonNamingPolicy.SnakeCaseUpper, | ||
| JsonKnownNamingPolicy.KebabCaseLower => JsonNamingPolicy.KebabCaseLower, | ||
| _ => JsonNamingPolicy.CamelCase, |
There was a problem hiding this comment.
This doesn't feel right to me, an invalid policy should probably result in no changes being made. It should probably also trigger a diagnostic if using the source generator.
This was referenced Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #108232
My first walk in this park, so some guidance is very much appreciated.
Not sure if I shouldn't add a JsonNamingPolicy property to
JsonTypeInfo, might make some stuff cleaner.Still missing
JsonMetadataServices.Helpers.cs