Add trustedHTML via alias/re-export of htmlSafe #20939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Estimated Asset SizesDiff --- main/out.txt 2025-06-23 17:58:14.000000000 +0000
+++ pr/./pr-15831737610/out.txt 2025-06-23 18:08:28.000000000 +0000
@@ -1,34 +1,34 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 408.76 KB │ 228.78 KB ║
+║ Total │ 408.84 KB │ 228.88 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤═══════════╤══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼──────────╢
-║ Total │ 239.15 KB │ 147.1 KB ║
+║ Total │ 239.23 KB │ 147.2 KB ║
╟──────────────────────┼───────────┼──────────╢
-║ -internals │ 35.39 KB │ 25.43 KB ║
-║ application │ 12.83 KB │ 7.66 KB ║
+║ -internals │ 35.44 KB │ 25.49 KB ║
+║ application │ 12.83 KB │ 7.62 KB ║
║ array │ 12.66 KB │ 7.32 KB ║
║ canary-features │ 304 B │ 419 B ║
-║ component │ 1.07 KB │ 976 B ║
+║ component │ 1.07 KB │ 1004 B ║
║ controller │ 1.8 KB │ 1.36 KB ║
║ debug │ 11.4 KB │ 7.92 KB ║
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 823 B │ 583 B ║
+║ helper │ 823 B │ 570 B ║
║ instrumentation │ 2.43 KB │ 1.78 KB ║
-║ modifier │ 669 B │ 601 B ║
+║ modifier │ 669 B │ 614 B ║
║ object │ 33.78 KB │ 20.79 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 385 B │ 331 B ║
-║ routing │ 58.05 KB │ 33.42 KB ║
+║ renderer │ 385 B │ 327 B ║
+║ routing │ 58.05 KB │ 33.43 KB ║
║ runloop │ 2.2 KB │ 1.33 KB ║
║ service │ 859 B │ 741 B ║
-║ template │ 396 B │ 343 B ║
+║ template │ 430 B │ 390 B ║
║ template-compilation │ 429 B │ 366 B ║
║ template-compiler │ 57.81 KB │ 30.44 KB ║
║ template-factory │ 94 B │ 160 B ║Details
|
wagenet
reviewed
Jun 20, 2025
| @@ -456,7 +456,7 @@ export { | |||
| type FunctionBasedHelper, | |||
| type FunctionBasedHelperInstance, | |||
| } from './lib/helper'; | |||
| export { SafeString, htmlSafe, isHTMLSafe } from './lib/utils/string'; | |||
| export { SafeString, trustedHTML, isTrustedHTML, htmlSafe, isHTMLSafe } from './lib/utils/string'; | |||
There was a problem hiding this comment.
Not to bike shed on this, since I'm happy to see this land, even as-is, but what about trustHTML so the method is a verb?
There was a problem hiding this comment.
Also, I'd really love to see SafeString become TrustedHTML as well, but I know that's more of a lift.
There was a problem hiding this comment.
am fan, verb fits more with what we're doing, and I'll reject all noun-proposals going forward for this haha
There was a problem hiding this comment.
Also, I'd really love to see SafeString become TrustedHTML as well, but I know that's more of a lift.
ya, I could alias this, too
|
I'm 👍 but types are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
htmlsafe is a misleading phrase, so here we are aliasing to what we really mean: that we trust the HTML
we should do an RFC to deprecate htmlSafe