[ios][prebuild] Added backwards compatible use of prebuild through cocoapods #52223

chrfalch · 2025-06-24T12:31:58Z

Summary:

Instead of declaring two different sets of Pods for prebuilt and build from source, this commit now keeps the pod structure the same for both modes so that consuming libraries can expect to have the same pods and header files available - without this, libraries would have to be updated to take advantage of the prebuilds.

This PR does:

Added React-Core-prebuilt as a pod in React-Core if prebuilt is enabled
Simplified react_native_pods to keep pods structure and add React-Core-prebuilt pod if prebuilts are enabled
Added function for selecting source sets based on prebuilt/build from source
Package.swift was missing the RCTVibration target. This commit adds this target.

To be able to function both in prebuilt and in regular build from source mode, all podspecs are now using the switch function podspec_sources so that they only include header files if we are in prebuild mode.

Also added React-Core-prebuilt as dependency on React-Core if we are in prebuilt mode so that we install the React.XCFramework.

Changelog:

[IOS] [FIXED] - Added backwards compatible use of prebuild through cocoapods

Test Plan:

Tested in RN-Tester both with and without prebuild.

This introduces the first working version of building React Native apps on iOS using prebuilt RNCore and cocoapods. - Added React-Core-prebuilt.podspec for installing/consuming XCFrameworks - Added logic in react_native_pods.rb for switching between build from source and using prebuilts - Added rncore.rb - utilities for the ReactCore prebuilts - Updated rndependencies with some extra error handling modelled after rncode.rb - Added support for hard linking headers and modules in each inner framework in the XCFramework in xcframework.js Swift: To enable support for the objective-c types from swift, the swift compiler uses a module map to gather exports from the framework (module.modulemap). This file basically points to an umbrella header file that exports the valid objective-c types (non c++) to Swift. In addition these files are read from the DerivedData and not the project source - so it is a bit hard to control everyting. I was initially not able to use cocoapods own module definitions (module_name, module_file props) to use a custom module map. I finally found that these files are expected in the deriveddata (build folder) where only the active inner framework is copied - so then I had to hard link both module map and header files for each arch.

…stable

Co-authored-by: Christian Falch <875252+chrfalch@users.noreply.github.com>

Added support for prebuilt.

Added a few missing search paths

Package.swift was missing the RCTVibration target. This commit adds this target.

Instead of declaring two different sets of Pods for prebuilt and build from source, this commit now keeps the pod structure the same for both modes so that consuming libraries can expect to have the same pods and header files available - without this, libraries would have to be updated to take advantage of the prebuilds. This commit does: - Added React-Core-prebuilt as a pod in React-Core if prebuilt is enabled - Simplified react_native_pods to keep pods structure and add React-Core-prebuilt pod if prebuilts are enabled - Added function for selecting source sets based on prebuilt/build from source

To be able to function both in prebuilt and in regular build from source mode, all podspecs are now using the switch function podspec_sources so that they only include header files if we are in prebuild mode. Also added React-Core-prebuilt as dependency on React-Core if we are in prebuilt mode so that we install the React.XCFramework.

Reverting changes

packages/rn-tester/scripts/.build-with-prebuilds.sh

cipolleschi

There is a file that needs to be removed. The rest is good to me.

After adding the podspec_source function we needed to be a bit more explicit with types, so where source files was originally defined in a variable and contained more than one entry we now needed to wrap it in an explicit array.

facebook-github-bot · 2025-06-24T21:36:10Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-06-25T08:54:15Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…rn-core-final

facebook-github-bot · 2025-06-25T09:03:02Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: `Package.swift` was missing the `RCTVibration` target. This commit adds this target. ## Changelog: [Internal] - Added RCTVibration to SwiftPM Pull Request resolved: facebook#52223 Test Plan: Tested in RN-Tester both with and without prebuild. Differential Revision: D77257066

…k#52223) Summary: Instead of declaring two different sets of Pods for prebuilt and build from source, this commit now keeps the pod structure the same for both modes so that consuming libraries can expect to have the same pods and header files available - without this, libraries would have to be updated to take advantage of the prebuilds. This PR does: - Added React-Core-prebuilt as a pod in React-Core if prebuilt is enabled - Simplified react_native_pods to keep pods structure and add React-Core-prebuilt pod if prebuilts are enabled - Added function for selecting source sets based on prebuilt/build from source To be able to function both in prebuilt and in regular build from source mode, all podspecs are now using the switch function podspec_sources so that they only include header files if we are in prebuild mode. Also added React-Core-prebuilt as dependency on React-Core if we are in prebuilt mode so that we install the React.XCFramework. ## Changelog: [IOS] [FIXED] - Added backwards compatible use of prebuild through cocoapods Pull Request resolved: facebook#52223 Test Plan: Tested in RN-Tester both with and without prebuild. Rollback Plan: Differential Revision: D77296047 Pulled By: cipolleschi

Summary: Pull Request resolved: #52252 Instead of declaring two different sets of Pods for prebuilt and build from source, this commit now keeps the pod structure the same for both modes so that consuming libraries can expect to have the same pods and header files available - without this, libraries would have to be updated to take advantage of the prebuilds. This PR does: - Added React-Core-prebuilt as a pod in React-Core if prebuilt is enabled - Simplified react_native_pods to keep pods structure and add React-Core-prebuilt pod if prebuilts are enabled - Added function for selecting source sets based on prebuilt/build from source To be able to function both in prebuilt and in regular build from source mode, all podspecs are now using the switch function podspec_sources so that they only include header files if we are in prebuild mode. Also added React-Core-prebuilt as dependency on React-Core if we are in prebuilt mode so that we install the React.XCFramework. ## Changelog: [IOS] [FIXED] - Added backwards compatible use of prebuild through cocoapods Pull Request resolved: #52223 Test Plan: Tested in RN-Tester both with and without prebuild. Rollback Plan: Reviewed By: cortinico Differential Revision: D77296047 Pulled By: cipolleschi fbshipit-source-id: f3eb4d56b2a78bfc8e10ad852746be1ceaf828b2

react-native-bot · 2025-06-25T10:48:03Z

This pull request was successfully merged by @chrfalch in 07f6f70

^{When will my fix make it into a release? | How to file a pick request?}

facebook-github-bot · 2025-06-25T10:48:04Z

@cipolleschi merged this pull request in 07f6f70.

chrfalch and others added 22 commits June 18, 2025 17:36

refactor: extract abort code to helper function

1e8c963

refactor: simplify if check

0e91ead

refactor: rename podspec_source_download_prebuild_release_tarball to …

7b456c0

…stable

rename: release_tarball_url to stable

5adfe16

fix: handle XML requests properly

e0b0756

fix: remove resolve_redirect as it is not used

93dc62a

fix: remove resolve_redirect from rndependencies as it is not used

742c205

refactor: abort if use local rndeps when no file is present

284a20b

fix: fix build from source

ad732b8

chore: add task to TODO

08a6a1a

fix: revert change to dSYM path

0aa7989

Co-authored-by: Christian Falch <875252+chrfalch@users.noreply.github.com>

[ios][prebuild] fixed missing changes to ReactCodegen.podspec.template

6f1e48d

Added support for prebuilt.

[ios][prebuild] fixed header search paths in ReactCodegen template

3252173

Added a few missing search paths

fix: support build rn core from source with prebuild rn dep

b7b0013

Update snapshot of ReactCodegen.podspec.template

27d152c

fix: reset Podfile

c863979

[ios][prebuild] added missing RCTVibration target to Package.swift

9eb756e

Package.swift was missing the RCTVibration target. This commit adds this target.

[ios][prebuild] Reverted changes to ReactCodegen podspec template

af385d5

Reverting changes

[ios][prebuild] Added use of podspec_sources in React-RCTTest.podspec

c018d47

chrfalch requested a review from cipolleschi June 24, 2025 12:32

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jun 24, 2025

cipolleschi reviewed Jun 24, 2025

View reviewed changes

packages/rn-tester/scripts/.build-with-prebuilds.sh Outdated Show resolved Hide resolved

cipolleschi approved these changes Jun 24, 2025

View reviewed changes

Merge branch 'main' into @chrfalch/cocoa-pods-rn-core-final

1d1048c

cipolleschi and others added 7 commits June 24, 2025 19:41

chore: remove .build-with-prebuilds file

91ce089

fix: update ReactCodegen test snapshot

300ea08

fix: use a single definition for hermes-engine

4b03118

[ios][prebuild] fixed wrong type of source file

888902c

After adding the podspec_source function we needed to be a bit more explicit with types, so where source files was originally defined in a variable and contained more than one entry we now needed to wrap it in an explicit array.

fix: cocoapods also in hybrid mode (RNDep prebuild)

e04f0e1

chore: reset Podfile.lock

a42b9f7

fix: use the right source_files for modal

0d69d2d

Merge remote-tracking branch 'origin/main' into @chrfalch/cocoa-pods-…

d44a228

…rn-core-final

facebook-github-bot closed this in 07f6f70 Jun 25, 2025

react-native-bot added the Merged This PR has been merged. label Jun 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ios][prebuild] Added backwards compatible use of prebuild through cocoapods #52223

[ios][prebuild] Added backwards compatible use of prebuild through cocoapods #52223

Uh oh!

chrfalch commented Jun 24, 2025

Uh oh!

Uh oh!

cipolleschi left a comment

Uh oh!

facebook-github-bot commented Jun 24, 2025

Uh oh!

facebook-github-bot commented Jun 25, 2025

Uh oh!

facebook-github-bot commented Jun 25, 2025

Uh oh!

react-native-bot commented Jun 25, 2025

Uh oh!

facebook-github-bot commented Jun 25, 2025

Uh oh!

Uh oh!

[ios][prebuild] Added backwards compatible use of prebuild through cocoapods #52223

[ios][prebuild] Added backwards compatible use of prebuild through cocoapods #52223

Uh oh!

Conversation

chrfalch commented Jun 24, 2025

Summary:

Changelog:

Test Plan:

Uh oh!

Uh oh!

cipolleschi left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 24, 2025

Uh oh!

facebook-github-bot commented Jun 25, 2025

Uh oh!

facebook-github-bot commented Jun 25, 2025

Uh oh!

react-native-bot commented Jun 25, 2025

Uh oh!

facebook-github-bot commented Jun 25, 2025

Uh oh!

Uh oh!