[Fizz] Suspensey Images for View Transition Reveals #33433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: d742611...fc19d72 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
sebmarkbage
force-pushed
the
fizzvtsuspensey2
branch
2 times, most recently
from
2750ea2 to
9632c54
Compare
Up to 500ms just like the client.
sebmarkbage
force-pushed
the
fizzvtsuspensey2
branch
from
9632c54 to
fc19d72
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
One possible downside of this approach is that it may prevent interaction for the period it waits where if we wait before the startViewTransition then it remains interactive in the meantime. |
rickhanlonii
approved these changes
Jun 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
Block the view transition on suspensey images Up to 500ms just like the client. We can't use `decode()` because a bug in Chrome where those are blocked on `startViewTransition` finishing we instead rely on sync decoding but also that the image is live when it's animating in and we assume it doesn't start visible. However, we can block the View Transition from starting on the `"load"` or `"error"` events. The nice thing about blocking inside `startViewTransition` is that we have already done the layout so we can only wait on images that are within the viewport at this point. We might want to do that in Fiber too. If many image doesn't have fixed size but need to load first, they can all end up in the viewport. We might consider only doing this for images that have a fixed size or only a max number that doesn't have a fixed size. DiffTrain build for [22b9291](22b9291)
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block the view transition on suspensey images Up to 500ms just like the client.
We can't use
decode()because a bug in Chrome where those are blocked onstartViewTransitionfinishing we instead rely on sync decoding but also that the image is live when it's animating in and we assume it doesn't start visible.However, we can block the View Transition from starting on the
"load"or"error"events.The nice thing about blocking inside
startViewTransitionis that we have already done the layout so we can only wait on images that are within the viewport at this point. We might want to do that in Fiber too. If many image doesn't have fixed size but need to load first, they can all end up in the viewport. We might consider only doing this for images that have a fixed size or only a max number that doesn't have a fixed size.