Skip to content

feat: create reusable Hero component #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: 2.x
Choose a base branch
from

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented May 21, 2025

Fixes #4202

Changes proposed in this pull request:

  • Create new reusable hero component to streamline the implementation of each variation

Reviewers should focus on:

  • Tried to keep the core abstract implementation as lightweight as possible
  • Perhaps some methods or the new class itself could be named better
  • Does this change need to be documented?
  • Are there any other Hero implementations i've missed?

Screenshot
DOM / UI should stay the same

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review May 22, 2025 09:12
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner May 22, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Reusable Hero Component
1 participant