-
Notifications
You must be signed in to change notification settings - Fork 415
test(bug): txtar to reproduce node crash on inserting many posts #4418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
test(bug): txtar to reproduce node crash on inserting many posts #4418
Conversation
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
This other PR could also address your issue more effectively: #4435 (preferred) |
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
c07cf25
to
d64bd11
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
This txtar uses r/demo/boards to create a new board and post. Then it runs a script to add 800 replies (inserting into the avl.Tree). To run the test:
This should succeed. (There is enough gas.) But the node becomes unresponsive. (In some tests, when I run the script in a terminal with gnokey and a gnoland node, it crashes with "fatal error: stack overflow".) See the gist with the stack dump.
As the txtar says, if it only adds 600 replies then it succeeds.
NOTE: This PR also has a commit with the fix in #4435 to allow
maketx run
to call a crossing function. When that PR is merged, this commit will be removed from this PR.