Skip to content

Conversation

wooffie
Copy link
Contributor

@wooffie wooffie commented Jun 25, 2025

We check for nil and in next line deference it tc.TypeUrl?
I found two places, which takes part in it

RELEASE NOTES:

  • xds: Fix possible panic when certain invalid resources are encountered

Copy link

linux-foundation-easycla bot commented Jun 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@Pranjali-2501 Pranjali-2501 self-requested a review June 28, 2025 09:18
@wooffie wooffie requested a review from Pranjali-2501 June 30, 2025 06:45
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (6207142) to head (17bf5bf).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
...ds/internal/xdsclient/xdsresource/unmarshal_cds.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8412      +/-   ##
==========================================
+ Coverage   82.26%   82.49%   +0.22%     
==========================================
  Files         414      414              
  Lines       40424    40434      +10     
==========================================
+ Hits        33255    33355     +100     
+ Misses       5802     5734      -68     
+ Partials     1367     1345      -22     
Files with missing lines Coverage Δ
xds/internal/xdsclient/xdsresource/filter_chain.go 92.91% <100.00%> (ø)
...ds/internal/xdsclient/xdsresource/unmarshal_cds.go 86.72% <0.00%> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pranjali-2501 Pranjali-2501 requested a review from dfawley July 1, 2025 09:27
@Pranjali-2501 Pranjali-2501 assigned dfawley and unassigned wooffie Jul 1, 2025
@Pranjali-2501 Pranjali-2501 added the Type: Feature New features or improvements in behavior label Jul 9, 2025
@Pranjali-2501 Pranjali-2501 added this to the 1.75 Release milestone Jul 9, 2025
Co-authored-by: Doug Fawley <dfawley@google.com>
@wooffie wooffie force-pushed the fix-xdsresource-config-parse branch from 19ed774 to 0111b1e Compare July 14, 2025 06:46
@wooffie wooffie force-pushed the fix-xdsresource-config-parse branch from 0111b1e to 8e947da Compare July 14, 2025 06:47
@dfawley
Copy link
Member

dfawley commented Jul 14, 2025

It looks like there are tests expecting a specific error string:

...
transport_socket missing typed_config or wrong type_url: "type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext" wantErr: "transport_socket field has unexpected typeURL"

@wooffie
Copy link
Contributor Author

wooffie commented Jul 18, 2025

I've tried to do naive replacement with new error massage, but it broke another tests. I will recheck this =)

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dfawley dfawley merged commit cc46259 into grpc:master Jul 18, 2025
16 checks passed
dimpavloff pushed a commit to dimpavloff/grpc-go that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Requires Reporter Clarification Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants