-
Notifications
You must be signed in to change notification settings - Fork 4.6k
xdsclient: typed config nil better nil checks #8412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8412 +/- ##
==========================================
+ Coverage 82.26% 82.49% +0.22%
==========================================
Files 414 414
Lines 40424 40434 +10
==========================================
+ Hits 33255 33355 +100
+ Misses 5802 5734 -68
+ Partials 1367 1345 -22
🚀 New features to boost your workflow:
|
Co-authored-by: Doug Fawley <dfawley@google.com>
19ed774
to
0111b1e
Compare
0111b1e
to
8e947da
Compare
It looks like there are tests expecting a specific error string:
|
I've tried to do naive replacement with new error massage, but it broke another tests. I will recheck this =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
We check for nil and in next line deference it
tc.TypeUrl
?I found two places, which takes part in it
RELEASE NOTES: