Skip to content

[ja] Translate content/en/docs/tasks/administer-cluster/safely-drain-node.md into Japanese #51430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuto-kimura-g
Copy link
Contributor

@yuto-kimura-g yuto-kimura-g commented Jun 29, 2025

Description

Translate content/en/docs/tasks/administer-cluster/safely-drain-node.md into Japanese

Issue

Closes: #50381

Message

About the link to kubectl drain (L34, L85):
Following the upstream approach, I added the link as
[kubectl drain](/docs/reference/generated/kubectl/kubectl-commands/#drain).
However, when I run make container-serve locally and try accessing the link in my browser, it results in a 404 error (both in Japanese and English pages).
So I changed the link to
[kubectl drain](https://kubernetes.io/docs/reference/kubectl/generated/kubectl_drain/).
However, if I check the link from this page:
https://kubernetes.io/docs/tasks/administer-cluster/safely-drain-node/
It works correctly.

Although it doesn’t work locally for me, do you think I should keep the link aligned with the upstream version?
I’m not sure why it’s returning a 404 on my local environment.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inductor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2025
@k8s-ci-robot k8s-ci-robot requested review from nasa9084 and t-inu June 29, 2025 13:54
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2025
@t-inu
Copy link
Member

t-inu commented Jun 30, 2025

issue #50381 がオープン中であることに気づかず、issue #51081 (PR #51120 )で進めてしまっていました。
PR #51120 がすでにマージできそうな状態になっているため、申し訳ないのですが、今回はそちらを採用する形とさせていただきたいです。

kubectl drainへのリンクについては、実際に存在するページなので、そのままでよいのではと思います。
ローカル環境での挙動は、私も試してみます。

@t-inu
Copy link
Member

t-inu commented Jul 3, 2025

私のローカル環境でも、以下は404でした。
http://localhost:1313/docs/reference/generated/kubectl/kubectl-commands/#drain

さしあたって、次のように最後のスラッシュを.htmlにすると、表示はできました(#22042 (comment) より)。
http://localhost:1313/docs/reference/generated/kubectl/kubectl-commands.html#drain

kubectlコマンドのリファレンスの生成と、ローカルでのプレビュー方法は、以下のページに記載がありました。
Generating Reference Documentation for kubectl Commands
試してはいませんが、これに従えばローカルでの404は解消されるのではないかと。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Translate content/en/docs/tasks/administer-cluster/safely-drain-node.md into Japanese
3 participants